From the course: Programming Foundations: Conducting Code Reviews
Join today to access over 24,400 courses taught by industry experts.
How long should a code review really take
From the course: Programming Foundations: Conducting Code Reviews
How long should a code review really take
- [Instructor] A code review should not take hours and hours and hours. Sometimes an implementation change might be a few lines of code and the review takes 10 minutes. Other times, it can take longer. Ideally, the author has submitted a change that adds, deletes or modifies around 400 to 600 lines of code. If the author's changes are significant, meaning 1,000 plus lines of code, it's often better to break the contributions up into multiple submissions. Although sometimes, it's not possible. Ultimately, you should never spend more than 60 to 90 minutes reviewing another developer's code because there is a diminishing return. After 90 minutes, you've probably found most, if not all the defects you are able to find. If you still feel unsure, you can always ask another developer on the team to review the code changes or meet with the original author of the code. That being said, you shouldn't rush a code review. Reviewing code takes time and is important for maintaining an efficient…
Download courses and learn on the go
Watch courses on your mobile device without an internet connection. Download courses using your iOS or Android LinkedIn Learning app.
